Changeset dc9cf7b in subsurface


Ignore:
Timestamp:
Apr 25, 2017, 10:39:33 AM (7 months ago)
Author:
Dirk Hohndel <dirk@…>
Branches:
master
Children:
12a59ef
Parents:
cd9dc8f
git-author:
Jan Mulder <jlmulder@…> (04/24/17 09:29:33)
git-committer:
Dirk Hohndel <dirk@…> (04/25/17 10:39:33)
Message:

OSTC3 incorrect notice to upgrade firmware

See https://github.com/Subsurface-divelog/subsurface/issues/342. The reason is
that we never get a DC_EVENT_DEVINFO when doing a memory dump. Just do not
offer to update firmware when we are creating a libdc dump.

Full credits of this fix go to Anton.

Fixed-by: Anton Lundin <glance@…>
Signed-off-by: Jan Mulder <jlmulder@…>

File:
1 edited

Legend:

Unmodified
Added
Removed
  • desktop-widgets/downloadfromdivecomputer.cpp

    r45dd564 rdc9cf7b  
    386386        // this check will compair apples and oranges, firmware wise, then.
    387387        QString product(ui.product->currentText());
    388         if (product == "OSTC 3" || product == "OSTC 3+" ||
     388        //
     389        // We shouldn't do this for memory dumps.
     390        if ((product == "OSTC 3" || product == "OSTC 3+" ||
    389391                        product == "OSTC Cr" || product == "OSTC Sport" ||
    390                         product == "OSTC 4")
     392                        product == "OSTC 4") && !data.libdc_dump)
    391393                ostcFirmwareCheck = new OstcFirmwareCheck(product);
    392394}
Note: See TracChangeset for help on using the changeset viewer.