Opened 7 weeks ago

Last modified 7 weeks ago

#1112 new task

SAC calculation broken

Reported by: atdotde Owned by: Subsurface Team
Priority: critical Component: Other
Version: current git - add SHA in description Keywords:
Cc: Plattform (please give specifics in the ticket text): All

Description

dives/sac-test.xml

contains dives that are designed to have a SAC of 20l/min. But current master only computes 18.5l/min!

Change History (1)

comment:1 Changed 7 weeks ago by atdotde

  • Type changed from defect to task

It seems this originate from using real gas compressibility. The calculated SAC is back to 20.0 when the compressibility is set back to 1.0.

I suggest we still double check if the values we compute make sense (and then potential update the test cases).

Note: See TracTickets for help on using tickets.