Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#315 closed defect (fixed)

Once set, it is not possible to set the dive location again using the map

Reported by: abelloni Owned by: tcanabrava
Priority: minor Component: Qt-UI
Version: 3.9.1 BETA Keywords:
Cc: Plattform (please give specifics in the ticket text): Linux

Description

If the dive location is already set, it is not possible to set a new dive location by double clicking on the map until the current location is removed and the dive is saved.

Change History (6)

comment:1 Changed 4 years ago by DirkHH

Kinda true, kinda not.
Once a location is set you need to enter "edit mode" to change the location.
I guess that's a bit unintuitive... so I wonder what a better solution might be.
I don't really like to always have double click change locations. That's too easy to happen unintentionally (many map browsers zoom / center on double click - we actually just turned that off with our maps).
Should there be a tooltip? A button saying "edit location"?

Oh, and harv just mentioned on IRC that apparently the "change location when in edit mode" doesn't work anymore :-(

Last edited 4 years ago by DirkHH (previous) (diff)

comment:2 Changed 4 years ago by abelloni

Also, I don't know if I should open an other bug but editing the location while using french doesn't work at all. you either end up in the Gulf of Guinea or with a red Coordinates field that you can't save.

comment:3 Changed 4 years ago by DirkHH

Oh interesting. I bet locale handling of numbers messes with us here.
Can you post a sample string that you think should be valid and that gets you a red field - or alternatively a string that you enter and that is misinterpreted?

comment:4 Changed 4 years ago by Dirk Hohndel <dirk@…>

  • Resolution set to fixed
  • Status changed from new to closed

In d26f109fba9d5f6f3a78b907334affacce4ffaeb/subsurface:

Fixes Setting the dive-location via the map.

This patch adds a context menu to set the dive location
via the globe, being the dive with a coordinate or not.

It also fixes setting the dive location on edit mode.

Fixes: #315

Signed-off-by: Tomaz Canabrava <tcanabrava@…>
Signed-off-by: Dirk Hohndel <dirk@…>

comment:5 Changed 4 years ago by abelloni

So, in french (LC_ALL=fr_FR), that string is ending up red and can't be saved:
"N20° 26.17602' , O87° 0.68802'"

While using LC_ALL=en_US that string ends up yellow and can be saved:
"N20° 26.17602' , W87° 0.68802'"

Also, "N20°26.17602' , W87°0.68802'" ends up red but can be saved and is working fine.

comment:6 Changed 4 years ago by Dirk Hohndel <dirk@…>

In 917b47b79cb8accbedd2c49c569aaafb728914c5/subsurface:

Parse localized GPS string

Let's ALWAYS support the somewhat "international standard" N/S/W/E
characters, but ALSO support localized versions.

Fixes #315

Signed-off-by: Dirk Hohndel <dirk@…>

Note: See TracTickets for help on using tickets.