Opened 4 years ago

Closed 4 years ago

#326 closed defect (fixed)

table print does no print all dives in my dive list

Reported by: DirkHH Owned by: Subsurface Team
Priority: minor Component: Printing
Version: 3.9.1 BETA Keywords:
Cc: Plattform (please give specifics in the ticket text): Linux

Description

I have 267 dives, but only the first 251 are printed

Change History (2)

comment:1 Changed 4 years ago by Dirk Hohndel <dirk@…>

In 94f85bbef9e0b4079f17f6d995c3af381f3784de/subsurface:

Print: fix truncated table in "Table print" mode

The whole procedure here is quite confusing.
Once we have our model populated, we need to estimate where
to put page headers (each page has one) and to do that we
store a list of indexes, where a page would begin (pageIndexes).

But since a row can end up being chopped at the end of a page
we move it to a new page and this particular part was lacking
compensation for the moved row's height, when storing the *last*
pageIndex.

For N number of pages we are losing N - 1 dives, or such that
were previously transferred on a new page.

See #326

Signed-off-by: Lubomir I. Ivanov <neolit123@…>
Signed-off-by: Dirk Hohndel <dirk@…>

comment:2 Changed 4 years ago by Dirk Hohndel <dirk@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 5506fa4b38a5914e8149b3fd9283d9060df395bb/subsurface:

Print: fix issues when printing a lot of dives in table print

This patch improves the algorithm when estimating where
to put the new page header in the table and how we move
larger dive rows on a new page. It now performs a couple of
'passes', where the first one processes the table and the
second one is used to compensate for the lost space.

Fixes #326

Signed-off-by: Lubomir I. Ivanov <neolit123@…>
Signed-off-by: Dirk Hohndel <dirk@…>

Note: See TracTickets for help on using tickets.