Opened 4 years ago

Closed 4 years ago

#331 closed defect (fixed)

Problem setting dive location in non-English Subsurface

Reported by: henrik Owned by: tcanabrava
Priority: major Component: Qt-UI
Version: 3.9.1 BETA Keywords:
Cc: Plattform (please give specifics in the ticket text): Linux

Description

When I use the Norwegian version of Subsurface, double clicking the marble map doesn't always select the correct position in the map. The flag is placed far to the right of the click.

Example here: https://www.youtube.com/watch?v=XfJPpdkMl9g

Norwegian uses N/S/Ø/V as compass directions instead of N/S/E/W, so I guess it's got something to do with how those values are parsed/translated.

Change History (2)

comment:1 Changed 4 years ago by henrik

The bug happens if I first select an E location and then a W location (or visa versa), e.g. first on the right side of UK, then on the left.

And it happens with French locale as well.

comment:2 Changed 4 years ago by Dirk Hohndel <dirk@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 4f4b83ccbf85574d4a062dad2e125c764831f0d2/subsurface:

Correctly parse translated GPS coordinates

Minor oversight in commit 917b47b79cb8 ("Parse localized GPS string") - we
accepted the translated hemisphere indicators in the regular expression,
but then didn't use them later when comparing with the result of applying
the regular expression.

Fixes #331

Signed-off-by: Dirk Hohndel <dirk@…>

Note: See TracTickets for help on using tickets.