Opened 4 years ago

Closed 4 years ago

#344 closed enhancement (fixed)

merge or skip dives after divelogs.de download

Reported by: divelogs Owned by: tcanabrava
Priority: minor Component: Qt-UI
Version: 3.9.2 BETA Keywords: divelogs.de
Cc: Plattform (please give specifics in the ticket text): Mac

Description

each download from divelogs.de adds another set of dives with same values and dive numbers to the list. I'd skip the existing ones (check via date & time) and add only new ones. Merging would be hard I guess. As an alternative, only download dives that don't exist yet

Change History (2)

comment:1 Changed 4 years ago by DirkHH

I can reproduce this (actually, it doesn't happen for the newest dive for me, but to all other dives). I don't understand quite yet why it doesn't merge those dives, though.

As background, when importing dives from a anything but directly from the divecomputer, subsurface can't be sure that that is indeed the exact same dive that you are importing - so it is supposed to try to merge the data downloaded from divelogs.de with the existing data.

I need to figure out why clearly identical dives are not merged.

comment:2 Changed 4 years ago by Dirk Hohndel <dirk@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 4beb53f27e43dd522bcfc9855896d1065cc0b3fd/subsurface:

Actually process the dives downloaded from divelogs.de

Silly mistake in commit 93b5c0cd14fe ("Finish download from divelogs.de"):
parse_file() doesn't call process_dives() - the caller needs to do that.

Fixes #344

Signed-off-by: Dirk Hohndel <dirk@…>

Note: See TracTickets for help on using tickets.