Opened 3 years ago

Closed 3 years ago

#377 closed defect (fixed)

User defined tanks are not remembered

Reported by: karent Owned by: tcanabrava
Priority: minor Component: Qt-UI
Version: 4.0 Keywords:
Cc: Plattform (please give specifics in the ticket text): Linux

Description

User defined tanks are not visible on drop down tank list after Subsurface is restarted. (but weights are remembered)

related: I got a report that a tank that was redefined by user reverts back to default values "as soon as click in any other field" but I was not able to confirm that.

Attachments (2)

test cylinders.xml (2.3 KB) - added by karent 3 years ago.
weird logbook
Screenshot from 2013-12-21 20:59:16.png (225.9 KB) - added by karent 3 years ago.
lost dives

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by DirkHH

This is an issue that we had in 3.9.2 and earlier and only on a Mac.
This should have been fixed (and I tested it right after the fix went in)

Can you follow up some more to figure out what's what?

comment:2 Changed 3 years ago by karent

Dirk, are you referring to the first or the second problem?

As for the first, I've just had a hard time trying to reproduce it and thought it's working fine... but no, there is definitely something fishy going on... the cylinder I define sometimes shows or doesn't show on the list but I still cannot quite pinpoint the problem... but I found something better - I tried this:

  1. start Subsurface and create a new logbook
  2. add a dive, use standard cylinder and weights, save
  3. add a dive, define a new cylinder ("test cyl 1") and weight ("test weight 1"), save
  4. add a dive, see that newly defined cyl and weight are available (they are), define new items ("test cyl 2", "test weight 2"), save
  5. add a dive, use standard cylinder and weights, but see that all newly defined cyl and weight are available (so far so good...), save logbook
  6. exit program, run it again, open logbook
  7. now I have a wtf moment, as Subsurface shows just dive #4, other 3 dives are gone?! I verify by opening logbook file in text editor, it looks fine. Weird...
  8. add a new dive (#5) - previously defined cylinders and weights are no longer available

Screenshot and logbook attached.

Second issue:
Yes, I confirm that tank names are not remembered - both on Windows and Linux - if certain condition is met: Pick a tank from list, edit its name, click any other table cell... and the name reverts back to default. This happens only if mouse is used to change cells and applies only to tank type. Other fields are not affected. If one uses Enter or Tab to confirm - it seems to work fine.

Changed 3 years ago by karent

weird logbook

Changed 3 years ago by karent

lost dives

comment:3 Changed 3 years ago by DirkHH

So I can solve the mystery of why you lose all the dives.
They have almost exactly the same start time. So they get merged when you re-open the program with that dive file. I'll admit that that's a wee non-intuitive. We should warn people when they add a new dive if that will get merged with an existing one. And do the merge after the user said "OK" to that warning - not after the next reload. That would be much more comprehensible behavior.
I haven't looked into the "headline" issue of not remembering tanks - just wanted to address this issue.

comment:4 Changed 3 years ago by Dirk Hohndel <dirk@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 90ff8e672b911f17bb7849f9d8316577b3ed59cf/subsurface:

Update tank model with custom tanks used in XML files

Fixes #377

Signed-off-by: Dirk Hohndel <dirk@…>

Note: See TracTickets for help on using tickets.